Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increaseAllowance and decreaseAllowance have been deprecated in erc20.sol #320

Closed
c4-submissions opened this issue Sep 14, 2023 · 4 comments
Closed

increaseAllowance and decreaseAllowance have been deprecated in erc20.sol #320

c4-submissions opened this issue Sep 14, 2023 · 4 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working low quality report This report is of especially low quality primary issue Highest quality submission among a set of duplicates unsatisfactory does not satisfy C4 submission criteria; not eligible for awards

Comments

@c4-submissions
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2023-09-centrifuge/blob/512e7a71ebd9ae76384f837204216f26380c9f91/src/token/ERC20.sol#L139

Vulnerability details

Impact

The increase and decrease allowance functions can add more bugs, These functions may allow for further phishing possibilities see the next discussion

Proof of Concept

After a lot disscussion The increase and decrease allowance functions have been deprecate for several erc20 repositorys.

see the next disccusions:

Tools Used

manual, x, github

Recommended Mitigation Steps

Consider remove increase and decrease allowance functions.

Assessed type

Other
@c4-submissions c4-submissions added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Sep 14, 2023
c4-submissions added a commit that referenced this issue Sep 14, 2023
@c4-submissions
Jorgect issue #320
e467d6a
@raymondfam
Copy link

raymondfam commented Sep 15, 2023 •
edited
Loading

L-02 from the bot.

@c4-pre-sort
Copy link

raymondfam marked the issue as low quality report

@c4-pre-sort c4-pre-sort added the low quality report This report is of especially low quality label Sep 15, 2023
@c4-pre-sort
Copy link

raymondfam marked the issue as primary issue

@c4-pre-sort c4-pre-sort added the primary issue Highest quality submission among a set of duplicates label Sep 15, 2023
This was referenced Sep 15, 2023
Closed
Closed
Closed
Closed
Closed
@c4-judge
Copy link

gzeon-c4 marked the issue as unsatisfactory:
Out of scope

@c4-judge c4-judge added the unsatisfactory does not satisfy C4 submission criteria; not eligible for awards label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working low quality report This report is of especially low quality primary issue Highest quality submission among a set of duplicates unsatisfactory does not satisfy C4 submission criteria; not eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@raymondfam @c4-judge @c4-pre-sort @c4-submissions