There is no way to absorb the excess cash into reserves

[code423n4]

Lines of code

https://github.com/code-423n4/2023-07-moonwell/blob/fced18035107a345c31c9a9497d0da09105df4df/src/core/MErc20.sol#L12

Vulnerability details

Impact

Detailed description of the impact of this finding.
There is no way to absorb the excess cash into reserves

Proof of Concept

Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept.
Supply caps were taken from this PR, but there is other part internalCash is not being implemented. The internalCash and gulp function allows the protocol to efficiently manage its reserves. When the total supplied amount reaches the supply cap, additional funds supplied by users cannot be provided within the lending markets. The "gulp" function absorbs these excess funds into the protocol's reserves, making them available for future use.

    function gulp() external {
        uint256 cashOnChain = getCashOnChain();
        uint256 cashPrior = getCashPrior();

        uint excessCash = sub_(cashOnChain, cashPrior);
        totalReserves = add_(totalReserves, excessCash);
        internalCash = cashOnChain;
    }

compound-protocol/pull/95/files#diff-a4e078ce9296966ff7c709454713a8aff63ae2b262bdd947886afdb86ad007dfR124

Tools Used

Recommended Mitigation Steps

I think the way it has been implemented in PR is for a reason and it should be copied completed and not partly

Assessed type

Other

[c4-pre-sort]

0xSorryNotSorry marked the issue as primary issue

[ElliotFriedman]

compound does not have a gulp function. donated tokens that aren't donated using add to reserves just increase the share price.

[c4-sponsor]

ElliotFriedman marked the issue as sponsor disputed

[c4-judge]

alcueca marked the issue as unsatisfactory:
Insufficient proof

[alcueca]

No proof of a vulnerability actually existing.