New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead code in io.roach.data.jpa.RetryableTransactionAspect #11

Open

louispool opened this issue Aug 31, 2023 · 0 comments

louispool commented Aug 31, 2023 •

edited

Loading

Hi guys,

Any reason why the following block of code exists at line 67 of io.roach.data.jpa.RetryableTransactionAspect?

Throwable t = ex.getUndeclaredThrowable();
while (t instanceof UndeclaredThrowableException) {
    t = ((UndeclaredThrowableException) t).getUndeclaredThrowable();
}

Looks like code that was written before Throwable.getCause() was introduced.

Link to line:
https://github.com/cockroachlabs/roach-data/blob/7a0c18bde7996fb8a556109b733629caacdd6267/roach-data-jpa/src/main/java/io/roach/data/jpa/RetryableTransactionAspect.java#L67C17-L67C17

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment