From fa0e5ac76279012d6f108c1b283f8339fddae49c Mon Sep 17 00:00:00 2001
From: cockroacher <163405488+cockroacher@users.noreply.github.com>
Date: Sun, 19 May 2024 17:12:18 +0200
Subject: [PATCH] fix review comments

---
 .github/workflows/regression-test-404.yml                    | 5 ++---
 .github/workflows/regression-test-a11y-statement.yml         | 5 ++---
 .github/workflows/regression-test-email.yml                  | 5 ++---
 .../workflows/regression-test-google-lighthouse-based.yml    | 5 ++---
 .github/workflows/regression-test-pa11y.yml                  | 5 ++---
 .github/workflows/regression-test-standard-files.yml         | 5 ++---
 .github/workflows/regression-test-webbkoll.yml               | 5 ++---
 .github/workflows/regression-test-ylt.yml                    | 5 ++---
 8 files changed, 16 insertions(+), 24 deletions(-)

diff --git a/.github/workflows/regression-test-404.yml b/.github/workflows/regression-test-404.yml
index 31221f12..ab3ee347 100644
--- a/.github/workflows/regression-test-404.yml
+++ b/.github/workflows/regression-test-404.yml
@@ -17,7 +17,6 @@ jobs:
     strategy:
             matrix:
                 os: [ubuntu-latest, windows-latest]
-                config: ['general.review.improve-only=True']
                 version: [2]
     steps:
     - name: Check out repository code
@@ -32,10 +31,10 @@ jobs:
     - if: ${{ matrix.os == 'ubuntu-latest' }}
       name: RUNNING TEST - LINUX
       run: |
-         python default.py -t ${{ matrix.version }} -r -i sites.json -o data/testresult-${{ matrix.version }}.json --setting ${{ matrix.config }}
+         python default.py -t ${{ matrix.version }} -r -i sites.json -o data/testresult-${{ matrix.version }}.json
          python tools/verify_result.py -t ${{ matrix.version }}
     - if: ${{ matrix.os == 'windows-latest' }}
       name: RUNNING TEST - WINDOWS
       run: |
-         python default.py -t ${{ matrix.version }} -r -i sites.json -o data\testresult-${{ matrix.version }}.json --setting ${{ matrix.config }}
+         python default.py -t ${{ matrix.version }} -r -i sites.json -o data\testresult-${{ matrix.version }}.json
          python tools\verify_result.py -t ${{ matrix.version }}
diff --git a/.github/workflows/regression-test-a11y-statement.yml b/.github/workflows/regression-test-a11y-statement.yml
index 7e187b8c..a604210f 100644
--- a/.github/workflows/regression-test-a11y-statement.yml
+++ b/.github/workflows/regression-test-a11y-statement.yml
@@ -17,7 +17,6 @@ jobs:
     strategy:
             matrix:
                 os: [ubuntu-latest, windows-latest]
-                config: ['general.review.improve-only=True']
                 version: [26]
     steps:
     - name: Check out repository code
@@ -32,10 +31,10 @@ jobs:
     - if: ${{ matrix.os == 'ubuntu-latest' }}
       name: RUNNING TEST - LINUX
       run: |
-         python default.py -t ${{ matrix.version }} -r -i sites.json -o data/testresult-${{ matrix.version }}.json --setting ${{ matrix.config }}
+         python default.py -t ${{ matrix.version }} -r -i sites.json -o data/testresult-${{ matrix.version }}.json
          python tools/verify_result.py -t ${{ matrix.version }}
     - if: ${{ matrix.os == 'windows-latest' }}
       name: RUNNING TEST - WINDOWS
       run: |
-         python default.py -t ${{ matrix.version }} -r -i sites.json -o data\testresult-${{ matrix.version }}.json --setting ${{ matrix.config }}
+         python default.py -t ${{ matrix.version }} -r -i sites.json -o data\testresult-${{ matrix.version }}.json
          python tools\verify_result.py -t ${{ matrix.version }}
diff --git a/.github/workflows/regression-test-email.yml b/.github/workflows/regression-test-email.yml
index d86b1d4d..650f82c3 100644
--- a/.github/workflows/regression-test-email.yml
+++ b/.github/workflows/regression-test-email.yml
@@ -17,7 +17,6 @@ jobs:
     strategy:
             matrix:
                 os: [ubuntu-latest, windows-latest]
-                config: ['general.review.improve-only=True']
                 version: [24]
     steps:
     - name: Check out repository code
@@ -44,10 +43,10 @@ jobs:
     - if: ${{ matrix.os == 'ubuntu-latest' }}
       name: RUNNING TEST - LINUX
       run: |
-         python default.py -t ${{ matrix.version }} -r -i sites.json -o data/testresult-${{ matrix.version }}.json --setting ${{ matrix.config }}
+         python default.py -t ${{ matrix.version }} -r -i sites.json -o data/testresult-${{ matrix.version }}.json
          python tools/verify_result.py -t ${{ matrix.version }}
     - if: ${{ matrix.os == 'windows-latest' }}
       name: RUNNING TEST - WINDOWS
       run: |
-         python default.py -t ${{ matrix.version }} -r -i sites.json -o data\testresult-${{ matrix.version }}.json --setting ${{ matrix.config }}
+         python default.py -t ${{ matrix.version }} -r -i sites.json -o data\testresult-${{ matrix.version }}.json
          python tools\verify_result.py -t ${{ matrix.version }}
diff --git a/.github/workflows/regression-test-google-lighthouse-based.yml b/.github/workflows/regression-test-google-lighthouse-based.yml
index 35612505..dfd12dac 100644
--- a/.github/workflows/regression-test-google-lighthouse-based.yml
+++ b/.github/workflows/regression-test-google-lighthouse-based.yml
@@ -17,7 +17,6 @@ jobs:
     strategy:
             matrix:
                 os: [ubuntu-latest, windows-latest]
-                config: ['general.review.improve-only=True']
                 version: [1, 4, 5, 10, 22]
     steps:
     - name: Check out repository code
@@ -38,10 +37,10 @@ jobs:
     - if: ${{ matrix.os == 'ubuntu-latest' }}
       name: RUNNING TEST - LINUX
       run: |
-         python default.py -t ${{ matrix.version }} -r -i sites.json -o data/testresult-${{ matrix.version }}.json --setting ${{ matrix.config }}
+         python default.py -t ${{ matrix.version }} -r -i sites.json -o data/testresult-${{ matrix.version }}.json
          python tools/verify_result.py -t ${{ matrix.version }}
     - if: ${{ matrix.os == 'windows-latest' }}
       name: RUNNING TEST - WINDOWS
       run: |
-         python default.py -t ${{ matrix.version }} -r -i sites.json -o data\testresult-${{ matrix.version }}.json --setting ${{ matrix.config }}
+         python default.py -t ${{ matrix.version }} -r -i sites.json -o data\testresult-${{ matrix.version }}.json
          python tools\verify_result.py -t ${{ matrix.version }}
diff --git a/.github/workflows/regression-test-pa11y.yml b/.github/workflows/regression-test-pa11y.yml
index 8bd6fd5f..037078a7 100644
--- a/.github/workflows/regression-test-pa11y.yml
+++ b/.github/workflows/regression-test-pa11y.yml
@@ -19,7 +19,6 @@ jobs:
                 # os: [ubuntu-latest, windows-latest]
                 os: [ubuntu-20.04, windows-latest]
                 version: [18]
-                config: ['general.review.improve-only=True']
     steps:
     - name: Check out repository code
       uses: actions/checkout@v4
@@ -40,10 +39,10 @@ jobs:
     - if: ${{ matrix.os == 'ubuntu-20.04' }}
       name: RUNNING TEST - LINUX
       run: |
-         python default.py -t ${{ matrix.version }} -r -i sites.json -o data/testresult-${{ matrix.version }}.json --setting ${{ matrix.config }}
+         python default.py -t ${{ matrix.version }} -r -i sites.json -o data/testresult-${{ matrix.version }}.json
          python tools/verify_result.py -t ${{ matrix.version }}
     - if: ${{ matrix.os == 'windows-latest' }}
       name: RUNNING TEST - WINDOWS
       run: |
-         python default.py -t ${{ matrix.version }} -r -i sites.json -o data\testresult-${{ matrix.version }}.json --setting ${{ matrix.config }}
+         python default.py -t ${{ matrix.version }} -r -i sites.json -o data\testresult-${{ matrix.version }}.json
          python tools\verify_result.py -t ${{ matrix.version }}
diff --git a/.github/workflows/regression-test-standard-files.yml b/.github/workflows/regression-test-standard-files.yml
index ec194497..fd76e1ce 100644
--- a/.github/workflows/regression-test-standard-files.yml
+++ b/.github/workflows/regression-test-standard-files.yml
@@ -17,7 +17,6 @@ jobs:
     strategy:
             matrix:
                 os: [ubuntu-latest, windows-latest]
-                config: ['general.review.improve-only=True']
                 version: [9]
     steps:
     - name: Check out repository code
@@ -32,10 +31,10 @@ jobs:
     - if: ${{ matrix.os == 'ubuntu-latest' }}
       name: RUNNING TEST - LINUX
       run: |
-         python default.py -t ${{ matrix.version }} -r -i sites.json -o data/testresult-${{ matrix.version }}.json --setting ${{ matrix.config }}
+         python default.py -t ${{ matrix.version }} -r -i sites.json -o data/testresult-${{ matrix.version }}.json
          python tools/verify_result.py -t ${{ matrix.version }}
     - if: ${{ matrix.os == 'windows-latest' }}
       name: RUNNING TEST - WINDOWS
       run: |
-         python default.py -t ${{ matrix.version }} -r -i sites.json -o data\testresult-${{ matrix.version }}.json --setting ${{ matrix.config }}
+         python default.py -t ${{ matrix.version }} -r -i sites.json -o data\testresult-${{ matrix.version }}.json
          python tools\verify_result.py -t ${{ matrix.version }}
diff --git a/.github/workflows/regression-test-webbkoll.yml b/.github/workflows/regression-test-webbkoll.yml
index 5849d7a2..24edb2c6 100644
--- a/.github/workflows/regression-test-webbkoll.yml
+++ b/.github/workflows/regression-test-webbkoll.yml
@@ -17,7 +17,6 @@ jobs:
     strategy:
             matrix:
                 os: [ubuntu-latest, windows-latest]
-                config: ['general.review.improve-only=True']
                 version: [20]
     steps:
     - name: Check out repository code
@@ -32,10 +31,10 @@ jobs:
     - if: ${{ matrix.os == 'ubuntu-latest' }}
       name: RUNNING TEST - LINUX
       run: |
-         python default.py -t ${{ matrix.version }} -r -i sites.json -o data/testresult-${{ matrix.version }}.json --setting ${{ matrix.config }}
+         python default.py -t ${{ matrix.version }} -r -i sites.json -o data/testresult-${{ matrix.version }}.json
          python tools/verify_result.py -t ${{ matrix.version }}
     - if: ${{ matrix.os == 'windows-latest' }}
       name: RUNNING TEST - WINDOWS
       run: |
-         python default.py -t ${{ matrix.version }} -r -i sites.json -o data\testresult-${{ matrix.version }}.json --setting ${{ matrix.config }}
+         python default.py -t ${{ matrix.version }} -r -i sites.json -o data\testresult-${{ matrix.version }}.json
          python tools\verify_result.py -t ${{ matrix.version }}
diff --git a/.github/workflows/regression-test-ylt.yml b/.github/workflows/regression-test-ylt.yml
index 00c65e69..b1091a15 100644
--- a/.github/workflows/regression-test-ylt.yml
+++ b/.github/workflows/regression-test-ylt.yml
@@ -17,7 +17,6 @@ jobs:
     strategy:
             matrix:
                 os: [ubuntu-latest, windows-latest]
-                config: ['general.review.improve-only=True']
                 version: [17]
     steps:
     - name: Check out repository code
@@ -44,11 +43,11 @@ jobs:
     - if: ${{ matrix.os == 'ubuntu-latest' }}
       name: RUNNING TEST - LINUX
       run: |
-         python default.py -t ${{ matrix.version }} -r -i sites.json -o data/testresult-${{ matrix.version }}.json --setting ${{ matrix.config }}
+         python default.py -t ${{ matrix.version }} -r -i sites.json -o data/testresult-${{ matrix.version }}.json
          python tools/verify_result.py -t ${{ matrix.version }}
     - if: ${{ matrix.os == 'windows-latest' }}
       name: RUNNING TEST - WINDOWS
       run: |
-         python default.py -t ${{ matrix.version }} -r -i sites.json -o data\testresult-${{ matrix.version }}.json --setting ${{ matrix.config }}
+         python default.py -t ${{ matrix.version }} -r -i sites.json -o data\testresult-${{ matrix.version }}.json
          python tools\verify_result.py -t ${{ matrix.version }}