@@ -320,7 +320,6 @@ def get_interesting_urls(content, org_url_start, depth):
320
320
security_txt_url = f'{ root_url } .well-known/security.txt'
321
321
urls [security_txt_url ] = get_default_info (
322
322
security_txt_url , '.well-known/security.txt' , 'url.text' , 0.15 , 10 )
323
- # TODO: Lets look in DMARC records for emails.
324
323
325
324
if len (urls ) > 0 :
326
325
tmp = sorted (urls .items (), key = get_sort_on_precision )
@@ -848,7 +847,11 @@ def Rate_Use_of_PTR_for_SPF_Policies(global_translation, rating, result_dict, lo
848
847
return rating
849
848
850
849
851
- def Rate_Fail_Configuration_for_SPF_Policies (global_translation , rating , result_dict , local_translation ):
850
+ def Rate_Fail_Configuration_for_SPF_Policies (
851
+ global_translation ,
852
+ rating ,
853
+ result_dict ,
854
+ local_translation ):
852
855
if 'spf-uses-ignorefail' in result_dict :
853
856
has_spf_ignore_records_rating = Rating (
854
857
global_translation , REVIEW_SHOW_IMPROVEMENTS_ONLY )
@@ -932,7 +935,11 @@ def Rate_has_SPF_Policies(global_translation, rating, result_dict, local_transla
932
935
return rating
933
936
934
937
935
- def Rate_Too_many_DNS_lookup_for_SPF_Policies (global_translation , rating , result_dict , local_translation ):
938
+ def Rate_Too_many_DNS_lookup_for_SPF_Policies (
939
+ global_translation ,
940
+ rating ,
941
+ result_dict ,
942
+ local_translation ):
936
943
if 'spf-error-to-many-dns-lookups' in result_dict :
937
944
to_many_spf_dns_lookups_rating = Rating (
938
945
global_translation , REVIEW_SHOW_IMPROVEMENTS_ONLY )
@@ -1059,22 +1066,17 @@ def Validate_SPF_Policy(global_translation, local_translation, hostname, result_
1059
1066
elif section .startswith ('v=spf1' ):
1060
1067
c = 1
1061
1068
elif section .startswith ('mx' ) or section .startswith ('+mx' ):
1062
- # TODO: What do this do and should we rate on it?
1063
1069
c = 1
1064
1070
elif section .startswith ('a' ) or section .startswith ('+a' ):
1065
- # TODO: What do this do and should we rate on it?
1066
1071
c = 1
1067
1072
elif section .startswith ('ptr' ) or section .startswith ('+ptr' ):
1068
1073
# What do this do and should we rate on it?
1069
1074
result_dict ['spf-uses-ptr' ] = True
1070
1075
elif section .startswith ('exists:' ):
1071
- # TODO: What do this do and should we rate on it?
1072
1076
c = 1
1073
1077
elif section .startswith ('redirect=' ):
1074
- # TODO: What do this do and should we rate on it?
1075
1078
c = 1
1076
1079
elif section .startswith ('exp=' ):
1077
- # TODO: What do this do and should we rate on it?
1078
1080
c = 1
1079
1081
else :
1080
1082
result_dict ['spf-uses-none-standard' ] = True
0 commit comments