Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: add startOpts.RoachprodOpts.SkipWaitForSQL #141115

Open
srosenberg opened this issue Feb 11, 2025 · 1 comment
Open

roachtest: add startOpts.RoachprodOpts.SkipWaitForSQL #141115

srosenberg opened this issue Feb 11, 2025 · 1 comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. T-testeng TestEng Team

Comments

@srosenberg
Copy link
Member

srosenberg commented Feb 11, 2025

In [1], WaitForSQLReady was added immediately after roachprod.Start to ensure freshly started nodes are ready to serve (and authenticate) SQL sessions. This behavior is specific to roachtest; i.e., roachprod start remains unchanged. The reason for WaitForSQLReady is described in [2]. Essentially, part of the SQL subsystem is initialized asynchronously; session authentication isn't available until it's fully initialized.

Some roachtests, e.g., cluster-init, set SkipInit, effectively disabling automated cluster initialization. In that case, WaitForSQLReady is also skipped, since we can't place a definite upper bound on when SQL will eventually be ready. More recently, another roachtest, namely network/authentication was found to flake due to WaitForSQLReady [3]. While the test was made compatible with WaitForSQLReady, it's likely we will run into other examples in the future. Thus, we should add an opt-out via startOpts.RoachprodOpts.SkipWaitForSQL.

[1] #138109
[2] #137988
[3] #138806

Jira issue: CRDB-47618

@srosenberg srosenberg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team labels Feb 11, 2025
Copy link

blathers-crl bot commented Feb 11, 2025

cc @cockroachdb/test-eng

@srosenberg srosenberg added the E-quick-win Likely to be a quick win for someone experienced. label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. T-testeng TestEng Team
Projects
None yet
Development

No branches or pull requests

1 participant