lib: Drop unknown noVerticalAlign property from HelpIcon #19537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't documented anywhere on https://www.patternfly.org/components/icon/, no other instance uses it, and React complains about it: > React does not recognize the `noVerticalAlig` prop on a DOM element. We don't cover that bit in Cockpit's tests, but cockpit-machines does.
martinpitt
added
the
no-test
|
@KKoukiou You introduced that property, maybe you can still remember why? |
1 task
cockpituous
reviewed
Oct 27, 2023
| @@ -99,7 +99,7 @@ export const PasswordFormFields = ({ | |||
| <Popover bodyContent={password_label_info}> | |||
| <button onClick={e => e.preventDefault()} | |||
| className="pf-v5-c-form__group-label-help"> | |||
| <HelpIcon noVerticalAlign /> | |||
| <HelpIcon /> | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
|
In Machines we dropped this before cockpit-project/cockpit-machines@4cad663 and no pixel tests changed so let's merge it. |
jelly
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't documented anywhere on https://www.patternfly.org/components/icon/, no other instance uses it, and React complains about it: