testlib: when provisioning VMs allow to keep the original machine_class #19510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
reviewed
Oct 20, 2023
KKoukiou
force-pushed
the
testlib-provision-no-machine_class
branch
from
c4aea73
to
54b32e0
Compare
|
@martinpitt re-check please :) ? |
martinpitt
reviewed
Oct 23, 2023
test/common/testlib.py
Outdated
Comment on lines
1280
to
1283
| if inherit_machine_class: | ||
| machine_class = inherit_machine_class and self.machine_class or testvm.VirtMachine | ||
| else: | ||
| machine_class = testvm.VirtMachine |
There was a problem hiding this comment.
Please drop the if: and else: branch. Line 1281 is sufficient to cover all cases.
This use case is becoming now valid in the anaconda repository, where we overwrite the machine_class for running the VMs from ISO, however we will need to start provisioning 'normal' cloud VMs, to act as servers for network storage; see iscsi.
KKoukiou
force-pushed
the
testlib-provision-no-machine_class
branch
from
54b32e0
to
5774a3f
Compare
martinpitt
approved these changes
Oct 24, 2023
Ideally I would like to be able to provision only VMs as extra, and let the the default VM that the test spawns out of the provision list. I did not see this as straightforward therefore I went with this easy alternative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This use case is becoming now valid in the anaconda repository, where we overwrite the machine_class for running the VMs from ISO, however we will need to start provisioning 'normal' cloud VMs, to act as servers for network storage; see iscsi.