test: Add VM's XML and VM's log into link-patterns #19289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work: |
test/common/link-patterns.json: Invalid \escape: line 31 column 74 (char 882) |
martinpitt
added
the
no-test
martinpitt
reviewed
Sep 6, 2023
test/common/link-patterns.json
Outdated
| }, | ||
| { | ||
| "label": "vm xml", | ||
| "pattern": "Wrote ([A-Za-z0-9\\.\\-]+) XML to ([A-Za-z0-9\\.\\-]+\.xml)$", |
There was a problem hiding this comment.
use a raw string here; the other patterns ought to do that as well, to avoid the ugly double \\.
martinpitt
requested changes
Sep 6, 2023
test/common/link-patterns.json
Outdated
| @@ -1,29 +1,29 @@ | |||
| [ | |||
| { | |||
| "label": "screenshot", | |||
| "pattern": "Wrote screenshot to ([A-Za-z0-9\\-\\.]+\\.png)$", | |||
| "pattern": `Wrote screenshot to ([A-Za-z0-9\-\.]+\.png)$", | |||
There was a problem hiding this comment.
Sorry, I originally thought that was python -- too hard to pay full attention on the sprint. Of course this is json, there is no such thing as a raw string.
Capturing VM's xml and logs was implemented in [1], now it's time to also include the in our link-patterns. [1] cockpit-project/cockpit-machines#1158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capturing VM's xml and logs was implemented in [1], now it's time to also include the in our link-patterns.
[1] cockpit-project/cockpit-machines#1158