test: Wait for tooltips after scrolling stuff into view #19279
Conversation
|
I can't reproduce this locally. |
I have pushed some cleanups for the "rtl" code in testlib, but I don't think they fix any bugs related to this pixel failure. |
mvollmer
added
the
no-test
mvollmer
force-pushed
the
test-pixel-popups-after-scrolling
branch
3 times, most recently
from
a4e5335
to
e3a49e5
Compare
|
This changes some pixels: https://github.com/cockpit-project/pixel-test-reference/compare/e2bf1a1ca73377985f7841c2aa6e441743fa795c..6393fc7ded28291a42e483729ece488ffd805052 The metrics on mobile looks questionable. |
mvollmer
force-pushed
the
test-pixel-popups-after-scrolling
branch
from
e3a49e5
to
e165284
Compare
Yes, it's a flake. The mobile navbar appears in random positions. Some more delay is needed, I guess... |
mvollmer
force-pushed
the
test-pixel-popups-after-scrolling
branch
from
e165284
to
e70e0aa
Compare
This is really weird. The change that triggered seems to be the additional frame switching that we now do because of setting the direction of both the shell and the page. This particular test doesn't switch to "rtl", but just switching frames and setting attributes seems to upset some timing somewhere. Let's just keep the old beahvior of only putting the current frame into rtl, but with cleaner code. Fingers crossed. |
mvollmer
force-pushed
the
test-pixel-popups-after-scrolling
branch
from
e70e0aa
to
2c99d54
Compare
mvollmer
force-pushed
the
test-pixel-popups-after-scrolling
branch
from
2c99d54
to
023ef8a
Compare
Scrolling might trigger a tooltip (or popup) and thus we should wait for their animation to be over after scrolling.
mvollmer
force-pushed
the
test-pixel-popups-after-scrolling
branch
2 times, most recently
from
339f7fc
to
70ddfb0
Compare
mvollmer
force-pushed
the
test-pixel-popups-after-scrolling
branch
from
70ddfb0
to
940f90d
Compare
mvollmer
removed
the
no-test
mvollmer
force-pushed
the
test-pixel-popups-after-scrolling
branch
from
940f90d
to
bad736f
Compare
|
Most failures are unrelated and on my radar, doing a round of retries. At least this seems to fix the dreaded testUsed mobile flake which is almost impossible to get green. But this one is a genuine pixel test which seems related to shifting the page, so what you are trying to do here: https://cockpit-logs.us-east-1.linodeobjects.com/pull-19279-20230908-103623-bad736fd-fedora-38-other/pixeldiff.html#TestHistoryMetrics-testEvents-metrics-history-expanded-hour-dark) |
Scrolling might trigger a tooltip (or popup) and thus we should wait for their animation to be over after scrolling.
This fixes the TestStorageUsed-testUsed-popover-medium flake in #19268 for me.