network: distinguish create and edit dialogs #19209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
subhoghoshX
force-pushed
the
add-edit-dialog
branch
from
beefeb8
to
5583db7
Compare
|
Thanks! I think changing the titles would make sense as well. E.g. "Add VLAN" and "Edit VLAN" or "Edit VLAN settings". Please no "Add ... settings", that sounds weird. |
subhoghoshX
force-pushed
the
add-edit-dialog
branch
from
5583db7
to
dc4a837
Compare
|
Went with "Add VLAN" and "Edit VLAN settings". Oops! Too many tests failed to ignore... only TestFirewall.testNetworkingPage seem to be repeating. |
cockpituous
reviewed
Aug 29, 2023
| @@ -151,7 +151,8 @@ export const TeamDialog = ({ connection, dev, settings }) => { | |||
| <NetworkModal dialogError={dialogError} | |||
| idPrefix={idPrefix} | |||
| onSubmit={onSubmit} | |||
| title={_("Team settings")} | |||
| title={!connection ? _("Add team") : _("Edit team settings")} | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
| @@ -88,7 +88,8 @@ export const VlanDialog = ({ connection, dev, settings }) => { | |||
| <NetworkModal dialogError={dialogError} | |||
| idPrefix={idPrefix} | |||
| onSubmit={onSubmit} | |||
| title={_("VLAN settings")} | |||
| title={!connection ? _("Add VLAN") : _("Edit VLAN settings")} | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
|
We now have the expected pixel diffs. |
martinpitt
added
the
no-test
martinpitt
force-pushed
the
add-edit-dialog
branch
from
dc4a837
to
89f8342
Compare
martinpitt
force-pushed
the
add-edit-dialog
branch
from
89f8342
to
d133e30
Compare
martinpitt
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
I pushed the updated pixels. Only re-running a few tests now, as they already went green before, and the 3x retry is quite taxing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @garrett's suggestions here.
And here.
This needed to be a separate PR as the code/issue is shared between the other interface Dialogs.
For the time being, create dialogs have a "Add" button and edit dialogs have a "Save" button.Create Dialog:
Edit Dialog:
I haven't changed the titles yet; changing "Bond settings" to "Create bond settings" seems redundant and should be obvious from the context, but happy to get any feedback on that.