Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmf: Replace deprecated dnf --noautoremove option #18987

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Jun 21, 2023

This option got dropped in dnf 5, and thus this started to fail on Rawhide. Replace it with the corresponding option.

See https://bugzilla.redhat.com/show_bug.cgi?id=2216622


Should fix this rawhide TF failure. Let's see what else is wrong.

@martinpitt martinpitt added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Jun 21, 2023
@martinpitt martinpitt added the release-blocker Targetted for next release label Jun 21, 2023
@martinpitt martinpitt force-pushed the fix-dnf-5 branch 2 times, most recently from cc5a068 to 92e7547 Compare June 22, 2023 05:22
@martinpitt
Copy link
Member Author

martinpitt commented Jun 22, 2023

Meh, the --autoremove is really hard to avoid. It needs advanced combinatorics.

I filed https://bugzilla.redhat.com/show_bug.cgi?id=2216622 about it.

@martinpitt martinpitt force-pushed the fix-dnf-5 branch 2 times, most recently from 7f56a19 to e5ca750 Compare June 22, 2023 06:13
This option got dropped in dnf 5, and thus this started to fail on
Rawhide. Replace it with the corresponding option.

See https://bugzilla.redhat.com/show_bug.cgi?id=2216622
@martinpitt
Copy link
Member Author

Okay, this works, but it's super-ugly. I just got a better suggestion from the dnf bugzilla.

@martinpitt martinpitt changed the title fmf: Avoid dnf --noautoremove fmf: Replace deprecated dnf --noautoremove option Jun 22, 2023
@martinpitt martinpitt marked this pull request as ready for review June 22, 2023 07:34
@martinpitt martinpitt merged commit d533f23 into cockpit-project:main Jun 22, 2023
29 checks passed
@martinpitt martinpitt deleted the fix-dnf-5 branch June 22, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test For doc/workflow changes, or experiments which don't need a full CI run, release-blocker Targetted for next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants