Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl + Space closing the remote terminal, I use that shortcut as tmux leader key #21213

Open
thepragmaticmero opened this issue Oct 31, 2024 · 3 comments

Comments

@thepragmaticmero
Copy link

thepragmaticmero commented Oct 31, 2024

The shortcut Ctrl + Space is a hardcoded keyboard shortcut on the remote terminal https://ip:port/system/terminal, it closes the connection to the remote terminal. My configuration has Ctrl + Space as a leader key for tmux, the hardcoded shortcut inhibits the leader function on tmux. Disconnecting it.

Possible solutions:

  • Make the shortcut customizable.
  • Change the shortcut to something else.

Is there a cockpit.conf parameter that solves the problem maybe?

@garrett garrett transferred this issue from cockpit-project/cockpit-machines Nov 4, 2024
@garrett
Copy link
Member

garrett commented Nov 4, 2024

Note: I transferred this to the main Cockpit repo, instead of Cockpit Machines, as this appears to be related to the terminal in Cockpit (according to the URL), not the consoles in Cockpit Machines

I see this behavior on both the latest Firefox and Chrome on GNOME 47 on Fedora 41.

It's not an issue for the page itself, as hitting control+space doesn't do anything when the focus isn't on the widget, so I don't think it's intentional from the Cockpit side nor does it seem to be browser-related.

It does disconnect when you're focused on the terminal widget, so I'm thinking that it might be a bug in keyboard handling in the terminal JavaScript from xterm.js (which is what we use for the terminal). The demo at https://xtermjs.org/ doesn't close the session, however, so it might not be that, unless that has a fix our version doesn't have.

@jelly
Copy link
Member

jelly commented Nov 4, 2024

ctrl+space oopses cockpit for me and it shouldn't. So we should look into this.

@thepragmaticmero
Copy link
Author

It happened to me on firefox and on the Steam overlay browser (chromium).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants