From d7f9545d1f7abdc846941cc74203b1d8b7795368 Mon Sep 17 00:00:00 2001
From: Katerina Koukiou <kkoukiou@redhat.com>
Date: Wed, 21 Jun 2023 10:07:59 +0200
Subject: [PATCH] networkmanager: fix 'Services' radio button handler in 'Add
 ports to zone' dialog

---
 pkg/networkmanager/firewall.jsx           | 2 +-
 test/verify/check-networkmanager-firewall | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/pkg/networkmanager/firewall.jsx b/pkg/networkmanager/firewall.jsx
index 5be726ea43b..a0acddc590c 100644
--- a/pkg/networkmanager/firewall.jsx
+++ b/pkg/networkmanager/firewall.jsx
@@ -628,7 +628,7 @@ class AddEditServicesModal extends React.Component {
                                    id="add-services-dialog--services"
                                    value="services"
                                    isChecked={!this.state.custom}
-                                   onChange={(_event, value) => this.onToggleType(value)}
+                                   onChange={this.onToggleType}
                                    label={_("Services")} />
                             <Radio name="type"
                                    id="add-services-dialog--ports"
diff --git a/test/verify/check-networkmanager-firewall b/test/verify/check-networkmanager-firewall
index 2dd8759f280..13e27600e89 100755
--- a/test/verify/check-networkmanager-firewall
+++ b/test/verify/check-networkmanager-firewall
@@ -234,6 +234,12 @@ class TestFirewall(netlib.NetworkCase):
         b.click(".zone-section[data-id='public'] .add-services-button")
         b.wait_visible(".pf-v5-c-modal-box .service-list #firewall-service-pop3")
 
+        # check functionality of radio buttons
+        b.click("#add-services-dialog input[value='ports']")
+        b.wait_not_present("#filter-services-input")
+        b.click("#add-services-dialog input[value='services']")
+        b.wait_visible("#filter-services-input")
+
         # filter for pop3
         b.wait_visible(".pf-v5-c-modal-box .service-list #firewall-service-imap")
         b.set_input_text("#filter-services-input", "pop")