networkmanager: fix 'Services' radio button handler in 'Add ports to …

…zone' dialog
cockpit-project · Jun 22, 2023 · d7f9545 · d7f9545
1 parent 393f988
commit d7f9545
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/pkg/networkmanager/firewall.jsx b/pkg/networkmanager/firewall.jsx
@@ -628,7 +628,7 @@ class AddEditServicesModal extends React.Component {
                                    id="add-services-dialog--services"
                                    value="services"
                                    isChecked={!this.state.custom}
-                                   onChange={(_event, value) => this.onToggleType(value)}
+                                   onChange={this.onToggleType}
                                    label={_("Services")} />
                             <Radio name="type"
                                    id="add-services-dialog--ports"

diff --git a/test/verify/check-networkmanager-firewall b/test/verify/check-networkmanager-firewall
@@ -234,6 +234,12 @@ class TestFirewall(netlib.NetworkCase):
         b.click(".zone-section[data-id='public'] .add-services-button")
         b.wait_visible(".pf-v5-c-modal-box .service-list #firewall-service-pop3")
 
+        # check functionality of radio buttons
+        b.click("#add-services-dialog input[value='ports']")
+        b.wait_not_present("#filter-services-input")
+        b.click("#add-services-dialog input[value='services']")
+        b.wait_visible("#filter-services-input")
+
         # filter for pop3
         b.wait_visible(".pf-v5-c-modal-box .service-list #firewall-service-imap")
         b.set_input_text("#filter-services-input", "pop")