From bb18b8d9e441a05311b8bed75b2a12f0695e6d11 Mon Sep 17 00:00:00 2001 From: Allison Karlitskaya Date: Thu, 26 Oct 2023 13:00:15 +0200 Subject: [PATCH] workflows: drop pybridge-c8s.yml At some point this made sense as a very rudimentary smoke test that we weren't using language features that weren't compatible with Python 3.6, but we've long been running our entire unit tests suite under Python 3.6 in our tox workflow. What's more: this workflow often fails due to inability to fetch patches from the CentOS mirrors. Let's drop this one. --- .github/workflows/pybridge-c8s.yml | 71 ------------------------------ 1 file changed, 71 deletions(-) delete mode 100644 .github/workflows/pybridge-c8s.yml diff --git a/.github/workflows/pybridge-c8s.yml b/.github/workflows/pybridge-c8s.yml deleted file mode 100644 index 511205ba582c..000000000000 --- a/.github/workflows/pybridge-c8s.yml +++ /dev/null @@ -1,71 +0,0 @@ -# This is a temporary hack until we manage to get the integration tests going on C8S -name: pybridge -on: pull_request -jobs: - c8s: - runs-on: ubuntu-22.04 - permissions: {} - container: quay.io/centos/centos:stream8 - - timeout-minutes: 15 - steps: - - name: Install dependencies - run: | - for i in $(seq 5); do - if timeout 180 dnf install -y git-core python3-pytest python3; then - exit 0 - fi - sleep $((i * i * 5)) - done - exit 1 - - - name: Clone repository - uses: actions/checkout@v3 - - # https://github.blog/2022-04-12-git-security-vulnerability-announced/ - - name: Pacify git's permission check - run: git config --global --add safe.directory /__w/cockpit/cockpit - - - name: Install submodules - run: vendor/checkout - - - name: Check --help - run: PYTHONPATH=src python3 -m cockpit.bridge --help - - - name: Check --packages - # we can totally fake this, we only need a bunch of manifest.json - run: | - ln -s pkg cockpit - out=$(XDG_DATA_DIRS=. PYTHONPATH=src python3 -m cockpit.bridge --packages) - echo "$out" - echo "$out" | grep -q "^metrics" - - - name: Check a channel - # TODO: cockpit.print still broken with Python 3.6 - # PYTHONPATH=src python3 -m cockpit.print open fslist1 path=/etc watch=False - run: | - set -eux - (cat < /tmp/out - 64 - - { - "command": "init", - "host": "localhost", - "version": 1 - } - 105 - - { - "command": "open", - "channel": "ch1", - "payload": "fslist1", - "path": "/etc", - "watch": false - } - EOF - cat /tmp/out - grep -q '"event": "present"' /tmp/out - grep -q '"path": "os-release"' /tmp/out - - - # TODO: get pytests working, but that is seriously hard