Skip to content

Commit

Permalink
lib: Drop unknown noVerticalAlign property from HelpIcon
Browse files Browse the repository at this point in the history
This isn't documented anywhere on https://www.patternfly.org/components/icon/,
no other instance uses it, and React complains about it:

> React does not recognize the `noVerticalAlig` prop on a DOM element.
We don't cover that bit in Cockpit's tests, but cockpit-machines does.
  • Loading branch information
martinpitt committed Oct 27, 2023
1 parent bddb697 commit 5a132ab
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/lib/cockpit-components-password.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export const PasswordFormFields = ({
<Popover bodyContent={password_label_info}>
<button onClick={e => e.preventDefault()}
className="pf-v5-c-form__group-label-help">
<HelpIcon noVerticalAlign />
<HelpIcon />
</button>
</Popover>
}
Expand Down

0 comments on commit 5a132ab

Please sign in to comment.