-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows the search filters to be cleared or reset to the default #1216
Comments
I think you suggest to use https://www.patternfly.org/v4/components/search-input/#basic component. |
@KKoukiou @jelly Following are being used in cockpit-podman:
While the cockpit project is using:
I also tried to run the similar code on patternfly v4 website inside editor for |
Do you have a branch pushed somewhere we can check out to aid debugging? |
As we use the patternfly alpha release now, maybe you need to adjust the onChange? cockpit-project/cockpit@e9c78af#diff-3186be17476309370c4a7e009de79f2dc8d63591778b712d32a58e2e83c7c915R164 |
@jelly So there are two parts to this issue.
|
The |
Figured out that |
Add the same clear filter functionality as the logs page in Cockpit.
This probably means we have to change the
TextInput
into aSearchInput
andFormSelect
into aSelect
which supports onClear=()The text was updated successfully, but these errors were encountered: