Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird spacing at top of the page #177

Closed
garrett opened this issue Mar 24, 2021 · 2 comments
Closed

Weird spacing at top of the page #177

garrett opened this issue Mar 24, 2021 · 2 comments

Comments

@garrett
Copy link
Member

garrett commented Mar 24, 2021

  1. The top bar has inconsistent padding.
  2. The body has a line for some odd reason and the padding also seems off.
  3. The width of the page and the cards in the page feels strange.

Screenshot_2021-03-24 Software Updates - garrett Rain(5)
@KKoukiou
Copy link
Contributor 

1. The top bar has inconsistent padding.

2. The body has a line for some odd reason and the padding also seems off.

3. The width of the page and the cards in the page feels strange.

How wide should the cards be?

KKoukiou added a commit to KKoukiou/cockpit-ostree that referenced this issue Mar 25, 2021
@KKoukiou
Some alignment and padding related UI improvements
d9c6910 
* Fix inconsistent padding in header
* Fix issue with line appearing above the list
* Set the max width on the data list itself not the items, otherwise we
  see the borders spanning to the whole page

Fixes cockpit-project#177
@martinpitt martinpitt mentioned this issue Mar 28, 2021
Merged
@garrett
Copy link
Member Author

garrett commented Apr 12, 2021

How wide should the cards be?

Not sure.

There's a lot of blank space at the side, but the actions would be too far away. It's fine as is for now. I've posted a redesign of the page in #176 which will probably work around this issue by using expandable lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garrett @KKoukiou