From d82b2c0b5e631791c6bf84df2fa90c320b3061c9 Mon Sep 17 00:00:00 2001 From: Jelle van der Waa Date: Fri, 25 Oct 2024 11:33:29 +0200 Subject: [PATCH 1/2] Drop unneeded css overrides In PF5 a CodeBlockCode component no longer has a border so this overwrite does not apply anymore. --- src/components/vm/filesystems/vmFilesystemsCard.jsx | 2 -- src/components/vm/filesystems/vmFilesystemsCard.scss | 4 ---- 2 files changed, 6 deletions(-) delete mode 100644 src/components/vm/filesystems/vmFilesystemsCard.scss diff --git a/src/components/vm/filesystems/vmFilesystemsCard.jsx b/src/components/vm/filesystems/vmFilesystemsCard.jsx index 29b884ca8..32580dd85 100644 --- a/src/components/vm/filesystems/vmFilesystemsCard.jsx +++ b/src/components/vm/filesystems/vmFilesystemsCard.jsx @@ -40,8 +40,6 @@ import { domainCreateFilesystem, domainDeleteFilesystem, domainSetMemoryBacking import { vmId } from "../../../helpers.js"; import { DeleteResourceButton } from '../../common/deleteResource.jsx'; -import "./vmFilesystemsCard.scss"; - const _ = cockpit.gettext; export const VmFilesystemsCard = ({ connectionName, vmName, vmState, filesystems }) => { diff --git a/src/components/vm/filesystems/vmFilesystemsCard.scss b/src/components/vm/filesystems/vmFilesystemsCard.scss deleted file mode 100644 index a6de02c36..000000000 --- a/src/components/vm/filesystems/vmFilesystemsCard.scss +++ /dev/null @@ -1,4 +0,0 @@ -// PF4 sets some border to
 - remove this rule once we drop PF3 dependency
-pre.pf-v5-c-code-block__pre {
-    border: unset;
-}

From fca3383af6a3c9cf96bac14d9200eaa1f04c155b Mon Sep 17 00:00:00 2001
From: Jelle van der Waa 
Date: Fri, 25 Oct 2024 12:02:13 +0200
Subject: [PATCH 2/2] Remove unused vsock CSS overrides

The class `ct-input-group-spacer-sm` is not used anywhere in machines
code.
---
 src/components/vm/overview/vsock.jsx  | 2 --
 src/components/vm/overview/vsock.scss | 6 ------
 2 files changed, 8 deletions(-)
 delete mode 100644 src/components/vm/overview/vsock.scss

diff --git a/src/components/vm/overview/vsock.jsx b/src/components/vm/overview/vsock.jsx
index 4ed30f771..fec52a127 100644
--- a/src/components/vm/overview/vsock.jsx
+++ b/src/components/vm/overview/vsock.jsx
@@ -41,8 +41,6 @@ import {
     VSOCK_INFO_MESSAGE,
 } from './helpers.jsx';
 
-import "./vsock.scss";
-
 const _ = cockpit.gettext;
 
 const ASSIGN_AUTOMATICALLY = _("Assign automatically");
diff --git a/src/components/vm/overview/vsock.scss b/src/components/vm/overview/vsock.scss
deleted file mode 100644
index 6a9934745..000000000
--- a/src/components/vm/overview/vsock.scss
+++ /dev/null
@@ -1,6 +0,0 @@
-.ct-input-group-spacer-sm.pf-v5-l-flex {
-    // Limit width for select entries and inputs in the input groups otherwise they take up the whole space
-    > .pf-v5-c-select, .pf-v5-c-form-control:not(.pf-v5-c-select__toggle-typeahead) {
-      max-inline-size: 8ch;
-    }
-}