First batch of React error fixes #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
martinpitt
force-pushed
the
react-errors
branch
4 times, most recently
from
56e0e45
to
b01a5e4
Compare
martinpitt
force-pushed
the
react-errors
branch
2 times, most recently
from
a027d10
to
7f5e607
Compare
Replace assertTrue() with better alternatives to make failures useful for debugging. Fix the completely broken assertion in TestMachinesSettings, which was previously not actually doing the intended "cdrom" check.
All three calls in initState() are async. The App initialization must wait at least until getLoggedInUser() finished, as CreateStoragePoolAction requires the `loggedUser` property, which comes from the global state. Presumably this is true for a lot of other properties as well. So keep the "loading resources" screen until initState() finished, and also start with "loadingResources" right away to avoid an initial rendering of components.
All other bugs got fixed, but that one is hard. See issue cockpit-project#1272 for details.
This is non-trivial to fix, see issue cockpit-project#1273 for the details.
`cacheMode` is null if the domain XML does not specify a value, but the `value` should always point to an actual valid option. Fall back to "default".
This is a string, not a boolean property, so avoid a value of `false` if `keyInvalid` is falsy.
This picks up dropping the unknown `noVerticalAlign` from HelpIcon.
This fixes a React error: > Warning: A future version of React will block javascript: URLs as a security precaution. > Use event handlers instead if you can. And yes, we can! Add a stub handler to keep the label focusable.
This changed in PF5.
martinpitt
force-pushed
the
react-errors
branch
from
7f5e607
to
e7bf5c8
Compare
|
/devel succeeded, so re-running with full tests. This is a good first batch for landing. |
cockpituous
reviewed
Oct 27, 2023
| @@ -159,7 +159,10 @@ export const VmNeedsShutdown = ({ vm }) => { | |||
| position="bottom" | |||
| hasAutoWidth | |||
| bodyContent={body}> | |||
| <Label className="resource-state-text" href="javascript:null" color="blue" id={`vm-${vm.name}-needs-shutdown`} icon={<PendingIcon />}>{_("Changes pending")}</Label> | |||
| <Label className="resource-state-text" color="blue" id={`vm-${vm.name}-needs-shutdown`} | |||
| icon={<PendingIcon />} onClick={() => null}> | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
1 task
jelly
reviewed
Oct 27, 2023
| @@ -159,7 +159,10 @@ export const VmNeedsShutdown = ({ vm }) => { | |||
| position="bottom" | |||
| hasAutoWidth | |||
| bodyContent={body}> | |||
| <Label className="resource-state-text" href="javascript:null" color="blue" id={`vm-${vm.name}-needs-shutdown`} icon={<PendingIcon />}>{_("Changes pending")}</Label> | |||
| <Label className="resource-state-text" color="blue" id={`vm-${vm.name}-needs-shutdown`} | |||
| icon={<PendingIcon />} onClick={() => null}> | |||
There was a problem hiding this comment.
Wondering if dropping onClick is enough?
There was a problem hiding this comment.
I added it. It needs to have either a href= or an onClick handler to become focusable, and I think that was the original intent for that hack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts to address or at least confine the React errors that were spotted by fixing the console.error() checks in PR #1269