Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File editor leftover issue #726

Open
jelly opened this issue Sep 4, 2024 · 2 comments
Open

File editor leftover issue #726

jelly opened this issue Sep 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jelly
Copy link
Member

jelly commented Sep 4, 2024

When someone deletes a file while we are editing we now show a save button, but this will save it as root:root and not as admin:admin because we open the channel as superuser: true.

@jelly jelly added the bug Something isn't working label Sep 4, 2024
@leomoty
Copy link
Contributor

leomoty commented Sep 23, 2024

I am going to add this here, but it might be nice to do some work to at least dissuade the person from editing binary files:

file -i testleo
testleo: application/octet-stream; charset=binary

image

Which obviously nothing I do here could have a good outcome, so maybe read-only or something like that?

@jelly
Copy link
Member Author

jelly commented Sep 24, 2024

Yup, we should not offer editing binary files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants