Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow renaming / editing permissions of everything non directory/symlink/regular file #611

Open
jelly opened this issue Jun 28, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jelly
Copy link
Member

jelly commented Jun 28, 2024

It's unwanted behavior that we allow for example renaming of /dev/vda or a character device same goes for deletion, copying and changing permissions. (Although permissions can be debated)

So I would argue for something like:

    } else if (selected.length === 1 && ["dir", "reg", "lnk"].indexOf(selected[0].type || "reg") !== -1) {

That will basically make the right click menu empty and the sidebar's kebabdropdown menu empty so the kebabdropdown should be disabled.

@garrett @allisonkarlitskaya what do you think? This feels like a no-brainer to me.

@jelly jelly added the bug Something isn't working label Jun 28, 2024
@allisonkarlitskaya
Copy link
Member

I don't see anything wrong with renaming device files or other "specials". I particularly think that changing the mode of devices files might be very useful. Since you mention it, though: it's not possible to change the permissions of a symlink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants