Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSTcheckBear: Allow ignoring roles and directives #1723

Closed
jayvdb opened this issue May 13, 2017 · 10 comments
Closed

RSTcheckBear: Allow ignoring roles and directives #1723

jayvdb opened this issue May 13, 2017 · 10 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented May 13, 2017

rstcheck has cmdline args for ignoring directives and ignoring roles.

These need to be exposed via bear settings. This is blocking a proper fix for coala/coala#4211 (comment)

@jayvdb
Copy link
Member Author

jayvdb commented May 13, 2017

c.f. #1718 for a similar enhancement

@mridubhatnagar
Copy link

Instead of adding RSTcheckBear here. I can fix this issues in #4211 itself.

@jayvdb
Copy link
Member Author

jayvdb commented May 13, 2017

Instead of adding RSTcheckBear here. I can fix this issues in #4211 itself.

No. This is an enhancement for RSTcheckBear.

@mridubhatnagar
Copy link

Ohk so nothing has to be done with .coafile. I will have to go through RSTcheckBear.

@mridubhatnagar
Copy link

I understood what needs to be done. But for checking if everything works fine. I will have to add rstcheckBear to the .coafile of coala-bears repository.
rstcheckBear is not present in .coafile of coala-bears.

@jayvdb
Copy link
Member Author

jayvdb commented May 13, 2017

To test your changes, you need to add tests to tests/rest/RSTcheckBearTest.py, and not modify .coafile.

@mridubhatnagar
Copy link

Missing coverage 9-15.

@mridubhatnagar
Copy link

Can someone please help me with this. I am unable to get 100% code coverage. And not sure if changes are right or not.

@Makman2
Copy link
Member

Makman2 commented Aug 24, 2017

@mridubhatnagar it seems you are not working on the issue any more, and @umeshksingla said he has an urgent need for this feature. If you don't mind he would take this issue over :)

@umeshksingla please accept the invitation, then I'll assign the issue to you :)
PS: Hop onto our gitter channel, so you get various help: https://gitter.im/coala/coala

@Makman2
Copy link
Member

Makman2 commented Aug 24, 2017

Unassigned due to inactivity.

umeshksingla added a commit to umeshksingla/coala-bears that referenced this issue Aug 25, 2017
umeshksingla added a commit to umeshksingla/coala-bears that referenced this issue Aug 26, 2017
umeshksingla added a commit to umeshksingla/coala-bears that referenced this issue Aug 26, 2017
umeshksingla added a commit to umeshksingla/coala-bears that referenced this issue Aug 26, 2017
umeshksingla added a commit to umeshksingla/coala-bears that referenced this issue Sep 2, 2017
umeshksingla added a commit to umeshksingla/coala-bears that referenced this issue Sep 3, 2017
@rultor rultor closed this as completed in 801314a Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants