Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bear proposal planemo lint #1321

Open
jayvdb opened this issue Jan 18, 2017 · 5 comments
Open

Bear proposal planemo lint #1321

jayvdb opened this issue Jan 18, 2017 · 5 comments
Assignees

Comments

@jayvdb
Copy link
Member

jayvdb commented Jan 18, 2017

https://planemo.readthedocs.io/en/latest/commands.html#lint-command

@Shade5
Copy link

Shade5 commented Jan 21, 2017

a@a ~/workspace/coala $ planemo lint randomlines.xml
Out of the following, what should be shown by coala? The INFO: ... and WARNING: ... ?

Applying linter tests... CHECK
.. CHECK: 2 test(s) found.
Applying linter stdio... CHECK
.. INFO: No stdio definition found, tool will determine an error from stderr.
Applying linter output... WARNING
.. WARNING: Using format='input' on output data, format_source attribute is less ambiguous and should be used instead.
.. INFO: 1 outputs found.
Applying linter inputs... CHECK
.. INFO: Found 4 input parameters.
Applying linter help... CHECK
.. CHECK: Tool contains help section.
.. CHECK: Help contains valid reStructuredText.
Applying linter general... CHECK
.. CHECK: Tool defines a version [2.0.1].
.. CHECK: Tool defines a name [Select random lines].
.. CHECK: Tool defines an id [random_lines1].
Applying linter command... CHECK
.. INFO: Command uses deprecated 'interpreter' attribute.
.. INFO: Tool contains a command with interpreter of type [python].
Applying linter citations... WARNING
.. WARNING: No citations found, consider adding citations to your tool.
Applying linter tool_xsd... CHECK
.. INFO: File validates against XML schema.

@jayvdb
Copy link
Member Author

jayvdb commented Jan 22, 2017

@Shade5
Copy link

Shade5 commented Jan 22, 2017

So I map WARNING to MAJOR
INFO to INFO
and CHECK to NORMAL?
I was unsure as planemo lint gives no line numbers.

@Shade5
Copy link

Shade5 commented Jan 22, 2017

I've created a bear that takes this

.. CHECK: 2 test(s) found.
Applying linter stdio... CHECK
.. INFO: No stdio definition found, tool will determine an error from stderr.
Applying linter output... WARNING
.. WARNING: Using format='input' on output data, format_source attribute is less ambiguous and should be used instead.
.. INFO: 1 outputs found.
Applying linter inputs... CHECK
.. INFO: Found 4 input parameters.
Applying linter help... CHECK
.. CHECK: Tool contains help section.
.. CHECK: Help contains valid reStructuredText.
Applying linter general... CHECK
.. CHECK: Tool defines a version [2.0.1].
.. CHECK: Tool defines a name [Select random lines].
.. CHECK: Tool defines an id [random_lines1].
Applying linter command... CHECK
.. INFO: Command uses deprecated 'interpreter' attribute.
.. INFO: Tool contains a command with interpreter of type [python].
Applying linter citations... WARNING
.. WARNING: No citations found, consider adding citations to your tool.
Applying linter tool_xsd... CHECK
.. INFO: File validates against XML schema.

And gives this

Executing section Default...

randomlines.xml
|    | [INFO] PylintTutorialBear:
|    | 1 outputs found.
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit): 

randomlines.xml
|    | [INFO] PylintTutorialBear:
|    | Command uses deprecated 'interpreter' attribute.
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit): 

randomlines.xml
|    | [INFO] PylintTutorialBear:
|    | File validates against XML schema.
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit): 

randomlines.xml
|    | [INFO] PylintTutorialBear:
|    | Found 4 input parameters.
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit): 

randomlines.xml
|    | [INFO] PylintTutorialBear:
|    | No stdio definition found, tool will determine an error from stderr.
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit): 

randomlines.xml
|    | [INFO] PylintTutorialBear:
|    | Tool contains a command with interpreter of type [python].
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit): 

randomlines.xml
|    | [NORMAL] PylintTutorialBear:
|    | 2 test(s) found.
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit): 

randomlines.xml
|    | [NORMAL] PylintTutorialBear:
|    | Help contains valid reStructuredText.
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit): 

randomlines.xml
|    | [NORMAL] PylintTutorialBear:
|    | Tool contains help section.
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit): 

randomlines.xml
|    | [NORMAL] PylintTutorialBear:
|    | Tool defines a name [Select random lines].
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit): 

randomlines.xml
|    | [NORMAL] PylintTutorialBear:
|    | Tool defines a version [2.0.1].
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit): 

randomlines.xml
|    | [NORMAL] PylintTutorialBear:
|    | Tool defines an id [random_lines1].
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit): 

randomlines.xml
|    | [MAJOR] PylintTutorialBear:
|    | No citations found, consider adding citations to your tool.
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit): 

randomlines.xml
|    | [MAJOR] PylintTutorialBear:
|    | Using format='input' on output data, format_source attribute is less ambiguous and should be used instead.
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit):

What else should I add?

Shade5 added a commit to Shade5/coala-bears that referenced this issue Jan 22, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
@Shade5
Copy link

Shade5 commented Jan 22, 2017

Please review #1337

Shade5 added a commit to Shade5/coala-bears that referenced this issue Jan 22, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 added a commit to Shade5/coala-bears that referenced this issue Jan 23, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 added a commit to Shade5/coala-bears that referenced this issue Jan 23, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 added a commit to Shade5/coala-bears that referenced this issue Jan 23, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 added a commit to Shade5/coala-bears that referenced this issue Jan 23, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 added a commit to Shade5/coala-bears that referenced this issue Jan 25, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 added a commit to Shade5/coala-bears that referenced this issue Jan 26, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 added a commit to Shade5/coala-bears that referenced this issue Jan 26, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 added a commit to Shade5/coala-bears that referenced this issue Jan 26, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 added a commit to Shade5/coala-bears that referenced this issue Jan 27, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 added a commit to Shade5/coala-bears that referenced this issue Jan 28, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 added a commit to Shade5/coala-bears that referenced this issue Jan 28, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 added a commit to Shade5/coala-bears that referenced this issue Jan 28, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 added a commit to Shade5/coala-bears that referenced this issue Feb 7, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 added a commit to Shade5/coala-bears that referenced this issue Feb 13, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 pushed a commit to Shade5/coala-bears that referenced this issue Feb 25, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 pushed a commit to Shade5/coala-bears that referenced this issue Feb 28, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 pushed a commit to Shade5/coala-bears that referenced this issue Mar 3, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 pushed a commit to Shade5/coala-bears that referenced this issue Mar 6, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 pushed a commit to Shade5/coala-bears that referenced this issue Mar 22, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 pushed a commit to Shade5/coala-bears that referenced this issue Mar 22, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 pushed a commit to Shade5/coala-bears that referenced this issue Mar 22, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 pushed a commit to Shade5/coala-bears that referenced this issue Mar 28, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 pushed a commit to Shade5/coala-bears that referenced this issue Apr 18, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 pushed a commit to Shade5/coala-bears that referenced this issue Apr 18, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 pushed a commit to Shade5/coala-bears that referenced this issue Apr 18, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 pushed a commit to Shade5/coala-bears that referenced this issue Apr 24, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 pushed a commit to Shade5/coala-bears that referenced this issue Apr 24, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 pushed a commit to Shade5/coala-bears that referenced this issue Apr 24, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 pushed a commit to Shade5/coala-bears that referenced this issue Apr 24, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 pushed a commit to Shade5/coala-bears that referenced this issue Apr 26, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Shade5 pushed a commit to Shade5/coala-bears that referenced this issue May 19, 2017
Added a linter bear for planemo lint
Used `planemo lint` command

Closes coala#1321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants