-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDragon Helpers + CDragon + blahblahblah #54
Comments
…Champion.Helpers.getDataByIdWithParentAsId #54
In v0.8.21: DDragon.Champion.getDataById(championName: string)
DDragon.Champion.getDataByIdWithParentAsId(championName: string)
DDragon.Champion.listDataById()
DDragon.Champion.listDataByIdWithParentAsId()
DDragon.Champion.listFullDataById()
DDragon.Champion.listFullDataByIdWithParentAsId() |
Currently experimenting with an optional |
v0.8.22 Adding a manual Default regionconst kayn = Kayn()({ region: 'euw' })
const europeanList = await kayn.DDragon.Champion.list() Manual region callFor the current request, it overrides the default region. const kayn = Kayn()({ region: 'na' })
const europeanList = await kayn.DDragon.Champion.list().region('euw') |
@cnguy I've run into an issue related to the above optional |
I'll make an issue, since this one is kinda feature-packed as well as old. |
In light of my lack of static compatibility to prevent breaking code, I'll be working also on a few things over the next few days to help out everyone, and be working on things early (pushed ChampionRotation yesterday) and so I have much more time to think about releases. I'll admit that sometimes I don't prioritize certain new things because I don't have to use them (I didn't use static endpoints for example. My app pretty much just uses matchlist+challenger league+master league+literally saved copies of static data). However, I do want
kayn
to be easy-to-use and have a lot of examples, docs, and copy-pastable code, + good defaults so...One example of a DDragon helper is:
For example, DDragon.Champion.get(266) =>
The text was updated successfully, but these errors were encountered: