Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance review request process #481

Open
1 of 5 tasks
aliok opened this issue Aug 6, 2023 · 3 comments
Open
1 of 5 tasks

Governance review request process #481

aliok opened this issue Aug 6, 2023 · 3 comments

Comments

@aliok
Copy link
Member

aliok commented Aug 6, 2023

Let's set up a process for projects that ask our review of their governance.

Deliverables of this task that I can think of:

  • Issue template for governance review requests. Done: Governance review request issue template #572

  • Process setup and documented

    • What project members need to do (do self eval first, then ask for a review, then respond the TAG member questions, etc)
    • What TAG members need to do
    • ...
  • Also update the self assessment guide with the information coming out of this work

@aliok
Copy link
Member Author

aliok commented Sep 14, 2023

We discussed how a process can look like in a meeting and here's our brainstorming:

  1. Project creates an issue in TAG CS repository
  • Using a special GitHub issue type
    • GitHub issue template gives instructions
      • Self assessment template
      • Self assessment guide
  1. Project maintainers do the self-evaluation, and send a PR to TAG in a special “self-evaluations” folder.
  2. TAG members review self-evaluation, ask questions, but don’t alter. They merge when the project maintainers are happy with their self assessment.
  • TAG members might need to explicitly state that this is a self assessment and we’re happy to store these for projects.
  1. TAG members do their own review, using the self-assessment as the basis. They open a PR with the “official” tag review.
  2. Project (and sponsor) responds to eval (PR comments)
  • At this stage, we can wait for short fixes - things that can be fixed in a week.
  • But if there are bigger changes needed, we merge with the issues reported and later the project can ask for a new review.
  • With self evaluations though, we think issues would be identified earlier and there will be less time spent in this wait-for-fixes stage.
  1. Revise evaluation, revise PR
  2. Liaison (& sponsor?) approve PR

Notes:

  • We wanted to separate the self assessment PR and the TAG review PR as:
    • We didn’t want to alter the self assessment output (the name suggests it is a more personal thing).
    • There are issues with revising the PR contents, for example for volunteer reviewers
  • We didn’t want to use Google docs when interacting with projects because comments can be deleted and the whole thread will be vanished

Relevant Slack thread: https://cloud-native.slack.com/archives/CT6CWS1JN/p1694110297185549

@jberkus jberkus moved this from 🆕 New to 📋 Backlog in TAG Contributor Strategy Project Board Oct 5, 2023
aliok added a commit to aliok/tag-contributor-strategy that referenced this issue Feb 7, 2024
jberkus pushed a commit that referenced this issue Mar 6, 2024
* Update dates

Signed-off-by: Ali Ok <[email protected]>

* Self assessment should not have things marked as "Unknown".

The project maintainers are doing it, so, they won't be unknown.

Signed-off-by: Ali Ok <[email protected]>

* No point of "Summary and Assessment" section for self-assessments

Signed-off-by: Ali Ok <[email protected]>

* Remove a TODO as I noted it down in #481

Signed-off-by: Ali Ok <[email protected]>

* Update the instruction about the links to the website

Signed-off-by: Ali Ok <[email protected]>

* Move some content from the template to the guide

Signed-off-by: Ali Ok <[email protected]>

---------

Signed-off-by: Ali Ok <[email protected]>
@geekygirldawn
Copy link
Member

What's the status of this issue @aliok

@aliok
Copy link
Member Author

aliok commented May 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants