Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tokens should cause a better failure than I/O error #36

Open
krichter722 opened this issue Jun 25, 2017 · 1 comment
Open

Missing tokens should cause a better failure than I/O error #36

krichter722 opened this issue Jun 25, 2017 · 1 comment

Comments

@krichter722
Copy link
Contributor

When a user previously accessed a directory and listed the content, it's possible to open the file with an external application (e.g. a video file with VLC media player). If the user doesn't have a valid token he_she only gets I/O error whereas it'd be more helpful to give a feedback like "Missing authentication token (did you run clog [user]@[realm])?".

experienced with 6.11.2-1+ubuntu16.10 on Ubuntu 16.10

@jaharkes
Copy link
Member

The POSIX api doesn't give you that type of flexibility on returning errors from open(2).

As an aside, I'm pretty sure we try to return EPERM when tokens are missing. EIO is typically used for more critical issues, like when your Coda client has crashed and the kernel module is unable to talk to userspace.

There is a feedback channel in the form of 'codacon', which I believe does display some message when tokens have expired, but not when tokens have never been obtained in the first place. I'm pretty sure it does not trigger a message when an access fails because there are no tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants