Skip to content

Refactor redundant code in epi_slide, epi_slide_opt #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brookslogan opened this issue Apr 13, 2025 · 0 comments
Open

Refactor redundant code in epi_slide, epi_slide_opt #661

brookslogan opened this issue Apr 13, 2025 · 0 comments
Assignees

Comments

@brookslogan
Copy link
Contributor

There's redundant/reimplemented logic for padding and completion, maybe time filtering, etc. Also epi_slide implementation seems quite hard to follow through all its pieces (or to swap out / refactor out this duplicate logic), and epi_slide_opt isn't all that friendly either. Let's try eliminating some overlapping code and making things easier to read by unifying what is possible from the slide_one_group/epikey-type functions. E.g., we may want some conversions from the output of as_time_slide_computation, and from data.table and slider slide functions, to a common "simple" "slider"/"hopper" function that will take a padded&completed input time series and add output columns to it. Then the padding&completion interface and output filtering can be shared between epi_slide and epi_slide_opt.

@brookslogan brookslogan self-assigned this Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant