Skip to content

comments and some nit rewrites #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 5, 2025
Merged

Conversation

dsweber2
Copy link
Contributor

@dsweber2 dsweber2 commented Apr 3, 2025

Checklist

Please:

  • Request a review from one of the current main reviewers:
    brookslogan, nmdefries.
  • [NA] Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).
  • Styling and documentation checks. Make a PR comment with:
    • /document to check the package documentation and fix any issues.
    • /style to check the style and fix any issues.
    • /preview-docs to preview the docs.
    • See Actions GitHub tab to track progress of these commands.
  • See DEVELOPMENT.md for more information on the development
    process.

Change explanations for reviewer

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

@dsweber2 dsweber2 requested a review from brookslogan April 3, 2025 22:22
@dsweber2 dsweber2 self-assigned this Apr 4, 2025
@brookslogan
Copy link
Contributor

Thanks for the fixups!

@brookslogan brookslogan merged commit d1ba68e into lcb/archive-agg Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants