Address dist_quantiles()
deprecation
#634
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION
. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
process.
Change explanations for reviewer
dist_quantiles()
CHECK issue #631 for context. epipredict updated to usehardhat::quantile_pred()
rather than its owndist_quantiles()
backed by{distributional}
. It has some extra constraints and a bug, and epipredict adds onto the bugs. Current main goal is to avoid CHECK noise in unrelated PRs.hardhat::quantile_pred()
, but also skips it as we need something in Add specialized epix_slide for epi_slide_opt #611 or hardhat/epipredict fix to address currentis_locf
approach usingdplyr::lag
with triggers the hardhat+epipredict issue.Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch
dist_quantiles()
CHECK issue #631.