You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These are hanging around crowding documentation for these functions.
Consider either
Removing geo_type and time_type from the as_*() functions altogether. Though, it seems like time_type overrides could be useful in epi_archives currently, though perhaps as a workaround for other issues; if we do want these overrides, then we'd want to keep these parameters and add functionality back to them.
Moving geo_type and time_type to the end of the args list.
Consider also:
Moving all but the first argument to as_*() functions behind ... so that they must be called by name. This can help enable better error messages in legacy user code still passing *_type arguments positionally. It also may help code to read better.
This option is no longer as clean, as ... is not expected to be empty but now powers rename functionality... probably can still be made to work.
The text was updated successfully, but these errors were encountered:
These are hanging around crowding documentation for these functions.
Consider either
geo_type
andtime_type
from theas_*()
functions altogether. Though, it seems liketime_type
overrides could be useful inepi_archive
s currently, though perhaps as a workaround for other issues; if we do want these overrides, then we'd want to keep these parameters and add functionality back to them.geo_type
andtime_type
to the end of the args list.Consider also:
as_*()
functions behind...
so that they must be called by name. This can help enable better error messages in legacy user code still passing*_type
arguments positionally. It also may help code to read better....
is not expected to be empty but now powers rename functionality... probably can still be made to work.The text was updated successfully, but these errors were encountered: