Skip to content

[perf]: address regressions in slide_improvements #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dshemetov opened this issue Sep 20, 2024 · 1 comment
Open

[perf]: address regressions in slide_improvements #526

dshemetov opened this issue Sep 20, 2024 · 1 comment

Comments

@dshemetov
Copy link
Contributor

dshemetov commented Sep 20, 2024 •
edited
Loading

Perf has 3-4x slowdown due to validate_tibble and as_environment in as_slide_computation. To address later.

See here.
@brookslogan
Copy link
Contributor

brookslogan commented Sep 20, 2024 •
edited
Loading

Note that this slowdown is for tidyeval [epi_slide] only. I believe Dmitry found a speedup for at least formulas [on epi_slide, and no perf regression for epix_slide?].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dshemetov @brookslogan