Skip to content

Add lubridate::period support for epi_slide_mean etc #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsweber2 opened this issue Aug 1, 2024 · 3 comments
Open

Add lubridate::period support for epi_slide_mean etc #498

dsweber2 opened this issue Aug 1, 2024 · 3 comments

Comments

@dsweber2
Copy link
Contributor

dsweber2 commented Aug 1, 2024

In the process of adding step_epi_slide_mean, I noticed that given before=period("3 days") results in a window size of 1 day. either this should error or return the right value.

@dsweber2 dsweber2 changed the title Add lubridate::period support for epi_slide_mean etc Add lubridate::period support for epi_slide_mean etc Aug 1, 2024
@brookslogan
Copy link
Contributor

Was this given daily data or weekly data?

@dsweber2
Copy link
Contributor Author

fairly sure it was daily, sorry for not including a mwe

@dshemetov
Copy link
Contributor

dshemetov commented Sep 13, 2024

This should be fixed by #472, where before and after types are restricted to difftimes and integers, so you'd get a sensible error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants