Skip to content

epix_slide allows time_value and version to be different types & do unintended things #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookslogan opened this issue May 3, 2024 · 3 comments · Fixed by #472
Closed
Labels
bug Something isn't working

Comments

@brookslogan
Copy link
Contributor

E.g., tsibble::yearweek and integer (yearweeks are probably treated like number of weeks since some epoch; assuming this is the case since tsibble::yearweek(int) appears to work this way rather than e.g. parsing approach of epidatr). We do want to allow mixed types at some point; e.g., time_values representing weeks and versions representing datetimes. Datetime versions are likely more complicated, as, e.g., they probably won't have a regular period.

@brookslogan brookslogan added the bug Something isn't working label May 3, 2024
@brookslogan
Copy link
Contributor Author

@dshemetov seems relevant to what you're working on, not sure if you'll automatically knock this one out with changes you have planned.

@dshemetov
Copy link
Contributor

Thanks yea, haven't looked deeply, but looks relevant and hopefully something I can address.

@dshemetov
Copy link
Contributor

closed by #472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants