Skip to content

Add .by parameter to slides, etc., in order to mirror dplyr 1.1.0 #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
brookslogan opened this issue Feb 17, 2023 · 2 comments
Open

Add .by parameter to slides, etc., in order to mirror dplyr 1.1.0 #266

brookslogan opened this issue Feb 17, 2023 · 2 comments
Assignees
@brookslogan
Labels
enhancement New feature or request P2 low priority

Comments

@brookslogan
Copy link
Contributor

brookslogan commented Feb 17, 2023 •
edited
Loading

Interacts with #64. Also make sure not to describe epix_slide in #64 as becoming more summarize-like if it's actually going to be more reframe-like (although perhaps the envisioned changes now mean it will be neither, as reframe always ungroups).
@brookslogan brookslogan added enhancement New feature or request P2 low priority labels Feb 17, 2023
@brookslogan brookslogan self-assigned this Feb 17, 2023
@brookslogan
Copy link
Contributor Author

It looks like .by might use tidyselect rather than data masking; we should make sure to match.

@brookslogan brookslogan changed the title Add .by parameter to slides in order to mirror dplyr 1.1.0 Add .by parameter to slides, etc., in order to mirror dplyr 1.1.0 Feb 17, 2023
@brookslogan
Copy link
Contributor Author

Key compatibility question: how does .by work on already-grouped objects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brookslogan brookslogan

Labels
enhancement New feature or request P2 low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brookslogan