Skip to content

Consider replacing as_list_col, names_sep with dplyr behavior #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookslogan opened this issue Jan 27, 2023 · 2 comments
Closed

Consider replacing as_list_col, names_sep with dplyr behavior #261

brookslogan opened this issue Jan 27, 2023 · 2 comments
Labels
op-semantics Operational semantics; many potentially breaking changes here P2 low priority

Comments

@brookslogan
Copy link
Contributor

brookslogan commented Jan 27, 2023

We might want to make things more dplyr-like by not prefixing to begin with, eliminating as_list_col and let users just wrap their output in a list if they want the corresponding output column to be a list, and eliminating names_sep. (Might avoid confusion leading to filing #229.) Relates to #240.

Not sure if we should treat this as a P1 instead, as this would be a breaking change for users that do rely on the prefixed-unnest behavior.

@brookslogan brookslogan added P2 low priority op-semantics Operational semantics; many potentially breaking changes here labels Jan 27, 2023
@brookslogan
Copy link
Contributor Author

Another point of confusion this could avoid: if we provide a computation outputting atomic vectors, slides with as_list_col=TRUE won't actually output a list col.

@dshemetov
Copy link
Contributor

These were removed in #477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
op-semantics Operational semantics; many potentially breaking changes here P2 low priority
Projects
None yet
Development

No branches or pull requests

2 participants