Skip to content

Don't mess up guess_period in fill_through_version with "na" #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
brookslogan opened this issue Nov 7, 2022 · 0 comments
Open

Don't mess up guess_period in fill_through_version with "na" #243

brookslogan opened this issue Nov 7, 2022 · 0 comments
Labels
bug Something isn't working P2 low priority

Comments

@brookslogan
Copy link
Contributor

brookslogan commented Nov 7, 2022 •
edited
Loading

Currently [actually, after work on #64 is complete], unless the period is 1, this will mess up the period guessing in epix_slide. Also consider baking in the guessed period into archive metadata, similar to the default versions_end.
@brookslogan brookslogan added P2 low priority bug Something isn't working labels Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P2 low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brookslogan