Skip to content

Add way to refer to ref_time_value within f arg to epi_slide #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookslogan opened this issue Jul 27, 2022 · 3 comments
Closed

Add way to refer to ref_time_value within f arg to epi_slide #171

brookslogan opened this issue Jul 27, 2022 · 3 comments
Assignees
Labels
op-semantics Operational semantics; many potentially breaking changes here P2 low priority

Comments

@brookslogan
Copy link
Contributor

brookslogan commented Jul 27, 2022

See this Slack thread. See #165 for epix_slide-related discussion. Interacts with #161.

Within f, we'd like to refer to the ref_time_value we're performing the computation on.

  • The workaround suggested in the slider docs doesn't quite seem to be this exactly, but rather seems to be about attaching the ref_time_value to each computation after the fact.
  • It might be possible to calculate the ref_time_value from the available time_values in a time window + the align arg. However, we have to worry about gaps in the time_values and behavior near / at / beyond the edges of the range of time_values available. If it's possible, we could:
  • If there are problems due to gaps&edges in the previous approach, they might be resolved by creating a second df of time values with no gaps and extended around the edges, use hop2/slide2 instead of hop/slide; access to the second, df might make resolve some of the problematic cases for computing the ref_time_value. [On second look, this may not help; it looks like slide_index2 doesn't take two index vectors.]
  • We could move away from the slider package and just use a map.
  • We could try to improve the slider package.
  • We could try to implement an alternative slider-like routine. (This might also benefit epi_archive performance.)
@brookslogan brookslogan added P2 low priority op-semantics Operational semantics; many potentially breaking changes here labels Jul 27, 2022
@brookslogan
Copy link
Contributor Author

Another approach to correctly/simply recovering the ref_time_value by augmenting the original df / df group.

@nmdefries
Copy link
Contributor

nmdefries commented Apr 18, 2023

Link to the slider docs above is broken; an archived version is available here.

@nmdefries
Copy link
Contributor

Closed by #318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
op-semantics Operational semantics; many potentially breaking changes here P2 low priority
Projects
None yet
Development

No branches or pull requests

2 participants