Merge pull request #135 from dajmcdon/km-fix-middlel-middler

Resolved issue #127 and added tests for even-lengthed vectors as well.

Author: dajmcdon

Diff for: R/utils.R

@@ -23,8 +23,8 @@ Median = function(x) median(x, na.rm = TRUE)
 
 Start = function(x) x[1]
 End = function(x) x[length(x)]
-MiddleL = function(x) x[floor(length(x)/2)]
-MiddleR = function(x) x[ceiling(length(x)/2)]
+MiddleL = function(x) x[floor((length(x)+1)/2)]
+MiddleR = function(x) x[ceiling((length(x)+1)/2)]
 ExtendL = function(x) c(Start(x), x)
 ExtendR = function(x) c(x, End(x))
 

Diff for: tests/testthat/test-utils.R

@@ -26,8 +26,10 @@ test_that("Other capital letter functions work",{
   x <- c(1,2,3,4,5)
   expect_equal(Start(x),1)
   expect_equal(End(x),5)
-  expect_equal(MiddleL(x),2) # Questionable for odd length vectors
-  expect_equal(MiddleR(x),3) # Questionable for odd length vectors
+  expect_equal(MiddleL(x),3)
+  expect_equal(MiddleR(x),3)
+  expect_equal(MiddleL(x[-5]),2)
+  expect_equal(MiddleR(x[-5]),3)
   expect_equal(ExtendL(x),c(1,1,2,3,4,5))
   expect_equal(ExtendR(x),c(1,2,3,4,5,5))
 })