fix

Author: dshemetov

R/methods-epi_archive.R

@@ -113,19 +113,21 @@ epix_as_of <- function(x, version, min_time_value = -Inf, all_versions = FALSE,
   if (all_versions) {
     # epi_archive is copied into result, so we can modify result directly
     result <- epix_truncate_versions_after(x, version)
-    result$DT <- result$DT[time_value >= .min_time_value, ] # nolint: object_usage_linter
+    if (!identical(.min_time_value, -Inf)) {
+      # See below for why we need this branch.
+      result$DT <- result$DT[time_value >= .min_time_value, ] # nolint: object_usage_linter
+    }
     return(result)
   }
 
   # Make sure to use data.table ways of filtering and selecting
-  if (identical(.min_time_value, -Inf)) {
+  as_of_epi_df <- if (identical(.min_time_value, -Inf)) {
     # This branch is needed for `epix_as_of` to work with `yearmonth` time type
     # to avoid time_value > .min_time_value, which is NA for `yearmonth`.
-    filter_mask <- version <= .version
+    x$DT[version <= .version, ]
   } else {
-    filter_mask <- time_value >= .min_time_value & version <= .version
-  }
-  as_of_epi_df <- x$DT[filter_mask, ] %>% # nolint: object_usage_linter
+    x$DT[time_value >= .min_time_value & version <= .version, ]
+  } %>% # nolint: object_usage_linter
     unique(by = c("geo_value", "time_value", other_keys), fromLast = TRUE) %>%
     tibble::as_tibble() %>%
     dplyr::select(-"version") %>%

tests/testthat/_snaps/methods-epi_archive.md

@@ -1,7 +1,7 @@
-# current_time_value works as expected
+# epix_as_of_now works as expected
 
     Code
-      df %>% as_epi_archive() %>% current_time_value()
+      attr(df %>% as_epi_archive() %>% epix_as_of_now(), "metadata")$as_of
     Condition
       Error in `current_time_value()`:
       ! Unable to determine the latest time value for an integer time type. Use `epix_as_of` instead.