Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically import benchmark as opposed to having to statically compile it in #149

Closed
shuhaowu opened this issue Apr 11, 2022 · 2 comments
Closed

Dynamically import benchmark as opposed to having to statically compile it in #149

shuhaowu opened this issue Apr 11, 2022 · 2 comments

Comments

@shuhaowu
Copy link
Contributor

If I want to create a private benchmark, right now it seems like the only way is to fork benchbase and add the custom benchmark. It would be nice if that code can be maintained separately, and upstream-benchbase can be used directly.

A low priority feature request, but may help the adoption of benchbase a bit more.
@bpkroth
Copy link
Collaborator

bpkroth commented Apr 3, 2023

@jcamachor

@bpkroth
Copy link
Collaborator

bpkroth commented Dec 14, 2023

Hi, I think support for this has been added via the templated benchmarks introduced in #301.

Please let us know if there's additional features you think are still missing. Cheers!

@bpkroth bpkroth closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shuhaowu @bpkroth