Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permanently deceased holocard can be applied to non-permas #8319

Closed
2 of 3 tasks
zzzmike opened this issue Feb 2, 2025 · 0 comments · Fixed by #8322
Closed
2 of 3 tasks

Permanently deceased holocard can be applied to non-permas #8319

zzzmike opened this issue Feb 2, 2025 · 0 comments · Fixed by #8322
Labels
Bug Admin events aren't bugs Confirmed Bug We have the same at home!

Comments

@zzzmike
Copy link
Contributor

zzzmike commented Feb 2, 2025

Testmerges

#7850: 'Acid Runner: Acid gen cap' by TheManWithNoHands at commit 267636e #7607: 'Warden Praetorian rework (tm)' by Red-byte3D at commit af40285 #7650: 'Yet Another Attempt To Fix Vamp' by ihatethisengine at commit eaf5469 #8226: 'Project ARES: Turret IFF Controls' by realforest2001 at commit 87114a4 #7023: 'Research Rework Part Two: The Contract System.' by kiVts at commit 41664a6 #8026: 'Xenomorph Endgame changes' by Git-Nivrak at commit 3c6c296 #7320: 'Intel Detector fix' by blackcrystall at commit 5eef44e #8294: 'Marine Death Tracking' by Zonespace27 at commit 1b40968 #8277: 'Adds a shotgun choke for the M37A2' by VileBeggar at commit b0e2eeb #8305: 'Marine Spec Tracking' by Zonespace27 at commit a289266 #7816: 'Hostile Survivor Rework Revival' by BOBAMAx at commit 25805af

Round ID

26188

Description of the bug

In screenshot, patient is revivable but someone set their holocard as permanently deceased.

Image

What's the difference with what should have happened?

I don't think this is intended to be allowed to happen? Maybe throw an error message in chat when someone tries to do this?

How do we reproduce this bug?

  1. Apply the holocard to someone who is dead yet revivable.

Issue Bingo
@zzzmike zzzmike added the Bug Admin events aren't bugs label Feb 2, 2025
@Red-byte3D Red-byte3D mentioned this issue Feb 2, 2025
Merged
@Red-byte3D Red-byte3D added the Confirmed Bug We have the same at home! label Feb 4, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 4, 2025
@Red-byte3D @hry-gh
Fixes perma holocards being appliable to non-perma (#8322)
3a39104 
# About the pull request

fixes #8319
You can no longer apply the black holocard to people who are still
revivable

# Explain why it's good for the game

bugfix


# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: You can no longer apply the black holocard to people who are still
revivable
/:cl:

---------

Co-authored-by: InsaneRed <[email protected]>
Co-authored-by: harry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs Confirmed Bug We have the same at home!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes perma holocards being appliable to non-perma Red-byte3D/cmss13
2 participants
@Red-byte3D @zzzmike