-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UBSAN] HGCalVFECompressionImpl: shift exponent 4294967295 #46474
Comments
assign l1 |
New categories assigned: l1 @aloeliger,@epalencia you have been requested to review this Pull request/Issue and eventually sign? Thanks |
cms-bot internal usage |
A new Issue was created by @smuzaffar. @Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign upgrade |
New categories assigned: upgrade @Moanwar,@srimanob,@subirsarkar you have been requested to review this Pull request/Issue and eventually sign? Thanks |
@jbsauvan You're the name on HGCal I know. Could I ask you to please take a look at this? |
It seems there is a condition missing. It doesn't make sense to enter there if
|
Should be fixed in #46491 |
We have few UBSAN runtime errors [a]. This happens when exponent (
const uint32_t exponent = bitlen - mantissaBits_;
) is1
which causesexponent-2
to become4294967295
at https://github.com/cms-sw/cmssw/blob/master/L1Trigger/L1THGCal/src/HGCalVFECompressionImpl.cc#L53@cms-sw/l1-l2 , can you please look in this code and provide a fix ?
[a] https://cmssdt.cern.ch/SDT/jenkins-artifacts/ubsan_logs/CMSSW_14_2_X_2024-10-20-2300/logs/19/19a823aeb7adc34647332f165d28b627/log
The text was updated successfully, but these errors were encountered: