-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Code-style for cms-bot scripts #2097
Comments
A new Issue was created by @iarspider . @Dr15Jones, @antoniovilela, @smuzaffar, @sextonkennedy, @rappoccio, @makortel can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
See #2099 for results of reformatting. I will add github actions in a followup commit to that PR. |
|
thanks @iarspider for the suggestion and setting up the github action to check for |
Yes, let's close this, unless we want to implement more stricter checks (via flake8). |
To make maintaining cms-bot easier, especially for new people, I'd like to propose to start enforcing code format. We already enforce it for main cmssw repo.
For initial reformat, we can use black - it is guaranteed to preserve AST (abstract syntax tree, i.e. logic). After that, we can add other tools, like flake8, mypy
The text was updated successfully, but these errors were encountered: