Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request #62

Open
magnusarntzen opened this issue Oct 11, 2023 · 3 comments
Open

Feature request #62

magnusarntzen opened this issue Oct 11, 2023 · 3 comments

Comments

@magnusarntzen
Copy link

Since you asked for feedback...

What about implementing calculations of module competion factors (mcf)? These are values between 0-1 indicating whether a Bin has the required genes to complete a given reaksjon, e.g., 'denitrification' or 'methanogenesis'.

This can be done with the MetQy package in R (I have code if you want) and it would complement your output nicely.
I attach an example output for some of my samples with 150 bins.
MetQy_mcf.pdf

@cmkobel cmkobel added the enhancement New feature or request label Oct 11, 2023
@cmkobel
Copy link
Owner

cmkobel commented Oct 11, 2023

Thanks! Great idea! MCFs are definitely easier to interpret than p-values for GSEA. That R package looks neat, but the KO calls are already made in the kegg_diamond rule so we just need the table and algorithm that links the KOs to pathways and computes the MCF, then we're there! I'll look into a way of integrating that.

@magnusarntzen
Copy link
Author

magnusarntzen commented Oct 12, 2023 via email

@cmkobel
Copy link
Owner

cmkobel commented May 2, 2024

This will be solved by adding gapseq which calculates pathway completion fractions. It is well maintained and very powerful. Currently waiting for r-chnosz to be published on conda-forge so we can publish gapseq on bioconda, so we can finally add gapseq to asscom2.

@cmkobel cmkobel added this to the Reach 100 stars on Github milestone Jul 19, 2024
@cmkobel cmkobel self-assigned this Jul 23, 2024
@cmkobel cmkobel added feature request and removed enhancement New feature or request labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants