Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming of DynVar -> DynVarMIP within v01.00.31 incomplete #109

Open
matthew-mizielinski opened this issue Oct 4, 2019 · 3 comments
Open

Comments

@matthew-mizielinski
Copy link

There are a number of objects within the data request which have retained the mip attribute DynVar rather than DynVarMIP as noted in the release notes for 01.00.30.

For example see
http://clipc-services.ceda.ac.uk/dreq/u/93fcf41c-267c-11e7-8933-ac72891c3257.html

@JamesAnstey
Copy link

All the request items for DynVar still retain the old name "DynVar" in their "mip" attribute, so if I use the dreqPy software version 01.00.31.post3 to check the DynVar request using the new MIP name "DynVarMIP", I get nothing (i.e. it seems as if DynVar hasn't requested any variables). Changing the "mip" attribute to "DynVarMIP" for all these items fixes the problem and I get the same requested variables as I did for version 01.00.29, at least for the DECK + historical experiments.

@JamesAnstey
Copy link

JamesAnstey commented Oct 17, 2019

I notice the error doesn't seem to affect the command-line utility. E.g.

drq -m DynVarMIP -p 1 -e piControl --xls

still produces a spreadsheet containing variables requested by DynVarMIP. Could this be due to this code in scope.py (line 1037):

l1 = [i for i in self.dq.coll['requestItem'].items if i.mip in mip]

Here I presume i.mip would be 'DynVar' since this is what the request items have, and mip would be 'DynVarMIP'.

Nevertheless the inconsistency could affect people using the dreqPy tools in python scripts (as I am).

@martinjuckes
Copy link
Contributor

Thanks .. this occurs in 163 request items.

Fixed in 01.00.32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants