Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle diagrams make no sense #34

Closed
drlemmus opened this issue Nov 25, 2016 · 3 comments
Closed

Circle diagrams make no sense #34

drlemmus opened this issue Nov 25, 2016 · 3 comments

Comments

@drlemmus
Copy link

In the current implementation the circle diagram show two overlapping categories (unannotated and valid) as different sections. Just to give the hierarchy of categories:
Possible entries = missing + present
Missing = annotated + unannotated
Present = valid + obsolete

If you want to make all categories clickable, you can make two concentric circle diagrams with missing + present in the centre and with annotated + unannotated + valid + obsolete in the outer ring, aligned with the correct centre categories.

@cbaakman
Copy link
Contributor

Also, databanks in why_not have parents. Like mmcif is parent of dssp.

missing: entries in parent database, but not in child database
present: entries in child database, regardless of parent database
obsolete: entries in child, but not in parent
valid: entries in child and in parent

@jonblack
Copy link
Contributor

I replaced our custom pie chart code with chart.js because it's easier to maintain. The animation and interaction is just a free extra, but not so important in my opinion; certainly nice to have.

I like the idea of concentric circles, but chart.js doesn't support that. It's definitely possible with d3.js but that requires writing custom code. I've created #36 for this.

For now is it acceptable to just show annotated, unannotated, valid, and obsolete in the pie chart?

@drlemmus
Copy link
Author

Yes, that is the key information. The rest is decoration.

jonblack added a commit to jonblack/whynot that referenced this issue Nov 25, 2016
jonblack added a commit that referenced this issue Nov 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants