Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying BASIC_AUTH in JSON configuration #83

Open
zferentz opened this issue Apr 18, 2021 · 1 comment
Open

Specifying BASIC_AUTH in JSON configuration #83

zferentz opened this issue Apr 18, 2021 · 1 comment

Comments

@zferentz
Copy link

Hi,
Thanks for great module !!
Would appreciate your help - I think (but not 100% sure) that it's not possible to use BASIC_AUTH in yaml/json configuration as the current auth_type is passed via a Python object (CMRESHandler.AuthType.BASIC_AUTH) . I wonder if i missed anything ?

To solve my problem (use json configuration without forking the project) I'm deriving from CMRESHandler and just on the fly changing the string "BASIC_AUTH" into CMRESHandler.AuthType.BASIC_AUTH.
For example:

class MyCMRESHandler(cmreslogging.handlers.CMRESHandler):
    def __init__(self, *args, **kwargs):
        super().__init__(*args, **kwargs)
        if self.auth_type == "BASIC_AUTH":
            self.auth_type = cmreslogging.handlers.CMRESHandler.AuthType.BASIC_AUTH

and then in my json configuration i use "class": "MyCMRESHandler".
I wonder if there's a better way that i missed . Of course, i can fork the project and modify the __get_es_client but i'd rather avoid forking .

@mkhadher
Copy link

mkhadher commented Dec 8, 2021

This feature has been added in https://github.com/mkhadher/python-elasticsearch-logger. You can either specify python object CMRESHandler.AuthType.BASIC_AUTH or string "BASIC_AUTH". There's an example on how to use JSON config file to configure the Elastcisearch handler (PYESHandler)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants