Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger is not lazy, but CMRESHandler is #74

Open
Aethylred opened this issue Mar 19, 2020 · 0 comments
Open

Logger is not lazy, but CMRESHandler is #74

Aethylred opened this issue Mar 19, 2020 · 0 comments

Comments

@Aethylred
Copy link

Aethylred commented Mar 19, 2020

Pylint now warns that "Logger is not lazy" when you use % to do string formatting, meaning you just pass the strings and replacements directly rather than % (list, of, things, being, replaced)

However, CMRESHandler is lazy and just passes these on as arguments so when logger us used to log to file you see:

Completed provisioning 0 of 1077 directories for 0 of 0 users in 0:04:51.466437

But in elastic search you see:

msg:Completed provisioning %s of %s directories for %s of %s users  in %s args:0, 1077, 0, 0, 0:04:51.466437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant